Changeset 1801

Timestamp:

09/07/10 19:27:32 (17 months ago)

Author:

paparazzia

Message:

fix #373 (refix for admin notices)

Location:

trunk/site/admin

Files:

• adminwizard.php (modified) (5 diffs)
• importrace.php (modified) (3 diffs)
• players_pending_for_too_much_time.fixreport.php (modified) (1 diff)
• strange_engaged_in_unknown.php (modified) (1 diff)
• strange_results_for_unknown_races.php (modified) (1 diff)
• strange_unknown_flag.php (modified) (1 diff)
• uploadflag.php (modified) (1 diff)

trunk/site/admin/adminwizard.php

@@ -131 +131 @@
         case "unlock_boat":
             $query = "UPDATE users " ;
-            if ( quote_smart($_REQUEST['lock']) ) {
+            if ( get_cgi_var('lock') ) {
                 $querysgo = "SELECT coastpenalty FROM races WHERE idraces = ".$race;
                 $resgo = wrapper_mysql_db_query_writer($querysgo) or die("Query [$query] failed \n");
                 $row = mysql_fetch_assoc($resgo);
                 $coastpenalty = $row['coastpenalty'];
-                if ( intval(quote_smart($_REQUEST['coastpenalty'])) != $coastpenalty ) {
-                    $coastpenalty = intval(quote_smart($_REQUEST['coastpenalty']));
+                if ( intval(get_cgi_var('coastpenalty')) != $coastpenalty ) {
+                    $coastpenalty = intval(get_cgi_var('coastpenalty'));
                 }
                 $reltime = time() + $coastpenalty;
@@ -152 +152 @@
             break;
         case "maj_nextwp":
-             $nwp=quote_smart($_REQUEST['nwp']);
+             $nwp = get_cgi_var('nwp');
        $query = "update users set nextwaypoint= " .  $nwp . 
                "     where idusers = " .  $boat . 
@@ -163 +163 @@
        break;
         case "maj_position":
-             $longitude=quote_smart($_REQUEST['targetlong']);
-             $latitude=quote_smart($_REQUEST['targetlat']);
+             $longitude = get_cgi_var('targetlong');
+             $latitude  = get_cgi_var('targetlat');
        $query = "insert into positions (time, `long`, `lat`, idusers, race) " . 
                              "values   (" . 
@@ -178 +178 @@
        break;
         case "reset_pass":
-            $newpass=quote_smart($_REQUEST['newpass']);
+            $newpass = get_cgi_var('newpass');
             $query = "update users set password= '" .  $newpass . "'" .
                      "     where idusers = " .  $boat . 
@@ -187 +187 @@
             break;
         case "reset_username":
-            $newusern=quote_smart($_REQUEST['newusern']);
+            $newusern = get_cgi_var('newusern');
             $query = "update users set username= '" .  addslashes($newusern) . "'" .
                      "     where idusers = " .  $boat . 

trunk/site/admin/importrace.php

@@ -180 +180 @@
 // Main code
 
-    if ($_REQUEST["action"] != "import") {
+    if (get_cgi_var("action") != "import") {
         //Display the import form, import not started
 ?>
@@ -196 +196 @@
 
         //check from input
-        $idracefrom = intval($_REQUEST['idracefrom']) ;
-        $idraceto = intval($_REQUEST['idraceto']) ;
-        $importserver = htmlentities(quote_smart($_REQUEST['importserver']));
+        $idracefrom = intval(get_cgi_var('idracefrom')) ;
+        $idraceto = intval(get_cgi_var('idraceto')) ;
+        $importserver = htmlentities(get_cgi_var('importserver'));
 
         //Default is to print sql
@@ -209 +209 @@
         //FIXME: we should 'ping' the import server and check availability
 
-        if ($_REQUEST['confirm'] != 'yes') {
+        if (get_cgi_var('confirm') != 'yes') {
             //import first pass, checking in dryrun mode
             echo "<h3>Testing import of race #<b>$idracefrom</b> from server <b>$importserver</b> to race id #<b>$idraceto</b></h3>";

trunk/site/admin/players_pending_for_too_much_time.fixreport.php

@@ -4 +4 @@
     include ("htmlstart.php");
     include_once ("functions.php");
-    
         
-    if ($_REQUEST["action"] == "go" and $_REQUEST['confirm'] == "on" ) {
+    if (get_cgi_var("action") == "go" and get_cgi_var('confirm') == "on" ) {
         wrapper_mysql_db_query_writer("DELETE FROM players_pending WHERE updated < DATE_SUB(NOW(), INTERVAL $pending_limit DAY)");
         insertAdminChangelog(Array("operation" => "Deleting too old pending players"));

trunk/site/admin/strange_engaged_in_unknown.php

@@ -4 +4 @@
     include_once ("functions.php");
         
-    if ($_REQUEST["action"] == "go" and $_REQUEST['confirm'] == "on" ) {
+    if (get_cgi_var("action") == "go" and get_cgi_var('confirm') == "on" ) {
         wrapper_mysql_db_query_writer("UPDATE users SET engaged=0 WHERE engaged != 0 AND engaged NOT IN (SELECT DISTINCT idraces FROM races)");
         insertAdminChangelog(Array("operation" => "Update users engaged in unknown race"));

trunk/site/admin/strange_results_for_unknown_races.php

@@ -4 +4 @@
     include_once ("functions.php");
         
-    if ($_REQUEST["action"] == "go" and $_REQUEST['confirm'] == "on" ) {
+    if (get_cgi_var("action") == "go" and get_cgi_var('confirm') == "on" ) {
         wrapper_mysql_db_query_writer("DELETE FROM races_results WHERE races_results.idraces NOT IN (SELECT DISTINCT idraces FROM races)");
         insertAdminChangelog(Array("operation" => "Delete results for unknown races"));

trunk/site/admin/strange_unknown_flag.php

@@ -4 +4 @@
     include_once ("functions.php");
         
-    if ($_REQUEST["action"] == "go" and $_REQUEST['confirm'] == "on" ) {
+    if (get_cgi_var("action") == "go" and get_cgi_var('confirm') == "on" ) {
         wrapper_mysql_db_query_writer("UPDATE users SET country='000' WHERE country NOT IN (SELECT DISTINCT idflags FROM flags)");
         insertAdminChangelog(Array("operation" => "Update users with unknown flag"));

trunk/site/admin/uploadflag.php

@@ -4 +4 @@
     include_once ("functions.php");
 
-    $idflags = "".$_REQUEST['idflags'] ; 
+    $idflags = "".get_cgi_var('idflags', ''); 
 
-    if ($_REQUEST["action"] == "upload") {
+    if (get_cgi_var("action") == "upload") {
         if (function_exists("exif_imagetype") and exif_imagetype($_FILES['fic']['tmp_name']) != IMAGETYPE_PNG) {
             die("<h1>ERROR : Not a PNG file...</h1>");